search

doctrine / orm

Doctrine Object Relational Mapper (ORM)
https://www.doctrine-project.org/projects/orm.html
MIT License
9.86k stars 2.5k forks source link

[2.19.x] Fetching entities with Composite Key Relations and null values #11506

Closed michalbundyra closed 1 week ago

michalbundyra commented 1 week ago

Changes from #11486 into 2.19.x

greg0ire commented 1 week ago

Please squash both commits and use a summary of the description of #11486 . This should be understandable with the git log alone.

michalbundyra commented 1 week ago

@greg0ire thanks, squashed, rebased and force-pushed now.

greg0ire commented 1 week ago

use a summary of the description

Can you please amend your commit message to include a summary of the description?

greg0ire commented 1 week ago

More on this in the contributing guide.

michalbundyra commented 1 week ago

@greg0ire thanks, pushed now, hope it makes sense.

greg0ire commented 1 week ago

Thanks @michalbundyra !

michalbundyra commented 1 week ago

@greg0ire thanks for merging, I guess it will be pushed forward into 3.x as well, right?

There is still the other PR open with 3.2.x target: https://github.com/doctrine/orm/pull/11486 as it is quite different in terms of tests etc.

Thanks

greg0ire commented 1 week ago

I guess it will be pushed forward into 3.x as well, right?

Yes, it should get merged up at some point. When that happens, maybe we will have to look at your PR to resolve conflicts/adapt the code, or maybe not and then you can rebase and improve things.