doctrine / orm

Doctrine Object Relational Mapper (ORM)
https://www.doctrine-project.org/projects/orm.html
MIT License
9.93k stars 2.51k forks source link

Long column names break select query (Oracle) #11577

Open marcelowzd opened 1 month ago

marcelowzd commented 1 month ago

Bug Report

When using "find" method from symfony in columns with long names, the query built can start with an underscore, which creates an error in oracle database.

I'm currently using Symfony 7.1 with the following composer packages related to doctrine: "doctrine/dbal": "^3", "doctrine/doctrine-bundle": "^2.12", "doctrine/doctrine-migrations-bundle": "^3.3", "doctrine/orm": "^3.2",

Oracle database version is 12c (12.1.0.2.0)

Summary

It's not possible to retrieve any records from a table/entity where column names are too large.

Current behaviour

While trying to find any record, an error is shown.

How to reproduce

Create a simple entity called "test" with just one field of type string which will be managed by doctrine; Register a field with the following example:

[ORM\Column(name: "SN_PERMITE_FECHA_XPT_ANATOMIA", length: 1, options: ["fixed" => true, "default" => "N"])]

private ?string $permiteFechaContaAnatomia = null; In any controller, insert the repository for this entity and use $repository->bind(id: 1); After accessing the controller, doctrine will create the following query: SELECT t0.SN_PERMITE_FECHA_XPT_ANATOMIA AS _PERMITE_FECHA_XPT_ANATOMIA_19 FROM ORIGEM.TEST t0 WHERE t0.ID = ? The error will be shown.

Doctrine breaks the name of the field at the start (removing the SN) because it will reach the maximum length of the name, but by doing so it leaves the underscore which oracle doesn't support as the start character of an alias. I don't know if this is an oracle only problem though.

I can't rename the column, as the database is already old and the application which uses it is not ours.

I didn't find the set of classes that build the query as of the time i'm opening this issue, but my plan is to either add a double " or check for the underscore as the first character.

marcelowzd commented 1 month ago

As a workaround, i created a CustomQuoteStrategy and registered it as the default while using Oracle database. It changes the method getColumnAlias inside DefaultQuoteStrategy to remove the first character if it is an underscore.

while(str_startswith($columnName, "")){ $columnName = substr($columnName, 1, strlen($columnName)); }

Not sure if it is an optimal solution though, but i'm registering it here in case it helps in solving the problem because it worked in my case.