DDC-1048: Boolean type issue

[doctrinebot]

Jira issue originally created by user websirnik:

I'm having issues working with Doctrine2 boolean type. My mapping is basic:

    /****
     * @orm:Column(type="boolean", nullable=false, name="is_deleted")
     */
    protected $isDeleted;

When I'm trying to flush the object with $isDeleted=false (or true), the entity is not being added to the db. However when I set $isDeleted='0' (or '1') everything works fine.

I saw plenty of examples where people were using true and false, instead of '0' and '1'. But with MySQL it doesn't work. Doctrine maps boolean field as TINYINT(1) in MySQL. And I can see in Symfony2 Profiler the parameter in the query is "false"/"true", so here is data type conflict.

Doctrine doesn't transform true/false to 1/0 values.

[doctrinebot]

• relates to DDC-1394: Boolean literals in DQL queries get translated wrongly on PostgreSQL (PDOException)

[doctrinebot]

Comment created by @beberlei:

Boolean works fine for me with MySQL since forever, i cannot reproduce this. Can you come up with a reproducable test-case in our Testsuite? Otherwise odds are pretty slim to fix this, as i need to see whats happening.

[doctrinebot]

Comment created by websirnik:

Sorry don't know how to use your Testsuite.

So basically what I have:

Symfony 2 PR6 standard sandbox with the following config:

doctrine:
   dbal:
       dbname:   shop
       user:     root
       password: <sub>
       logging:  %kernel.debug%
   orm:
       auto*generate_proxy*classes: %kernel.debug%
       mappings:
           HelloBundle: </sub>

Then I have simple entity:

<?php

namespace Sensio\HelloBundle\Entity;

/****
 * @orm:Entity()
 * @orm:Table(name="product")
 */
class Product
{
    /****
     * @orm:Id
     * @orm:GeneratedValue
     * @orm:Column(type="integer")
     */
    private $id;

    /*** @orm:Column(type="text", nullable=false) **/
    private $name;

    /*** @orm:Column(type="boolean") **/
    private $inStock;

    public function getId()
    {
        return $this->id;
    }

    public function setName($name)
    {
        $this->name = $name;
    }

    public function getName()
    {
        return $this->name;
    }

    public function setInStock($inStock)
    {
        $this->inStock = $inStock;
    }

    public function getInStock()
    {
        return $this->inStock;
    }
}

Run the following commands:

php app/console doctrine:database:create
php app/console doctrine:schema:create

And finally I have simple action in the HelloController:

<?php

namespace Sensio\HelloBundle\Controller;

use Sensio\HelloBundle\Entity\Product;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;

class HelloController extends Controller
{
    public function indexAction($name)
    {
         $product = new Product();
         $product->setName($name);
         $product->setInStock(true);

         $em = $this->get('doctrine.orm.default*entity*manager');
         $em->persist($product);
         $em->flush();

         return $this->render('HelloBundle:Hello:index.html.twig', array('name' => $name));

    }
}

Go to the http://localhost/web/app_dev.php/hello/Product1

When I set 'true' for inStock attribute, and then flush object to the DB, it doesn't create a row. However when I write $product->setInStock('1') - that's works and the row appears in the DB. And $product->setInStock(1) that's doen't work again. That's a very strange behaviour, and I couldn't explain it anyhow.

[doctrinebot]

Comment created by @beberlei:

This is pretty old. Do you still use boolean types and does it work? The code suggests you maybe used Doctrine 2.0.x back then, does this work with Doctrine 2.1.x for you?

[doctrinebot]

Comment created by @asm89:

Lowered the priority of this issue until we receive more feedback.

[doctrinebot]

Comment created by @asm89:

Closing because we were unable to reproduce and no further feedback was provided.

[doctrinebot]

Comment created by wildlyinaccurate:

Hi guys, I was able to reproduce similar behaviour. Simply adding a boolean column to an entity prevents Doctrine from persisting new entities to the database. I am using a freshly-checked-out 2.2.2 with the Laravel PHP framework. Boolean columns have worked for me previously and I wondered whether Laravel's autoloaders were interfering with Doctrine somehow (just a stab in the dark).

Here is my Test entity:

<?php

namespace Entity;

/****
 * @Entity
 * @Table(name="test_entry")
 */
class Test
{

        /****
         * @Id
         * @Column(type="integer", nullable=false)
         * @GeneratedValue(strategy="AUTO")
         */
        protected $id;

        /****
         * @Column(type="string", length=40, nullable=false)
         */
        protected $string_col;

        public function getId()
        {
                return $this->id;
        }

        public function setStringCol($string_col)
        {
                $this->string*col = $string*col;
        }

        public function getStringCol()
        {
                return $this->string_col;
        }

}

Persisting a new Test entity like this works fine.

$test = new \Entity\Test;
$test->setStringCol('String value');
$em->persist($test);
$em->flush();

However, if I add a boolean column to the entity, the persist/flush operations seem to fail silently and the record is not inserted. The boolean column looks like this:

/****
 * @Column(type="boolean", nullable=false)
 */
protected $bool_col = false;

[doctrinebot]

Comment created by wildlyinaccurate:

Sorry, forgot to say that explicitly setting the value of bool_col doesn't make a difference. I have also tried setting the value to (int) 1 or 0, with the same results.

[doctrinebot]

Comment created by tobre:

My development environment is Ubuntu Linux, these boolean types is working well. After new developer put project up on his Windows 7 WAMP machine exactly the same problem happened. Firstly thought that MySQL is acting differently, but no, we connected MySQL to Linux server, still same problem. The solution was to replace boolean types to integers.

So perhaps you couldn't reproduce it because you tested it in Linux. You should run the same test on the Windows machine.

[doctrinebot]

Comment created by piotrjura:

Run into same problem here with Doctrine 2.3.x and MySQL 5.5.16 running on Windows 7 with Symfony2. Using query builder:

->where($qb->expr()->eq('c.private', 'false'))

I have to use literal 'false' or 0.

[doctrinebot]

Comment created by cordoval:

@beberlei @ocramius this should be reopened it is a present bug on 2.3+, i had the same problem rolled back and it works again.

[doctrinebot]

Comment created by @ocramius:

Won't reopen without failing test case

[doctrinebot]

Comment created by cordoval:

https://github.com/doctrine/doctrine2/pull/647

[doctrinebot]

Comment created by @ocramius:

[~cordoval] your test is not related with this issue :\

[doctrinebot]

Comment created by kwisatz:

We're experiencing the exact same issue. We have a model with quite a few boolean properties, such as

{panel} /****

• @var boolean *
• @ORM\Column(name="is_private", type="boolean", nullable=true) */ private $is_private;

/****

• @var boolean *
• @ORM\Column(name="deliver", type="boolean") */ private $deliver; {panel}

Now, when we set those properties to be booleans and try to persist:

{panel} $product ->setCode($params['code']) ->setName($params['name']) ->setIsPrivate(false) […] ->setDeliver(true);

$em->persist($product); $em->flush(); {panel}

The result is mysql not executing the prepared statement:

{panel} 3358 Query START TRANSACTION 3358 Prepare INSERT INTO product (code, name, min_quantity, is_private, deliver, price, long_distance, abroad, vatCategory_id) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?) 3358 Close stmt 3358 Query commit {panel}

Enabling EchoSQLLogger() shows the query using boolean as well:

{panel} "START TRANSACTION" INSERT INTO product (code, name, min_quantity, is_private, deliver, price, long_distance, abroad, vatCategory_id) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?) array(9) { [1]=> string(2) "05" [2]=> string(15) "abcdefg" [3]=> int(400) [4]=> bool(false) [5]=> bool(true) [6]=> int(100) [7]=> bool(false) [8]=> bool(false) [9]=> int(2) } array(9) { [1]=> string(6) "string" [2]=> string(6) "string" [3]=> string(7) "integer" [4]=> string(7) "boolean" [5]=> string(7) "boolean" [6]=> string(7) "decimal" [7]=> string(7) "boolean" [8]=> string(7) "boolean" [9]=> string(7) "integer" } "COMMIT" {panel}

Even passing integers does not work, the only thing working is passing "0" and "1" as strings.

[doctrinebot]

Comment created by kwisatz:

Sorry for this second comment, I wasn't aware that I wouldn't be able to edit my first one. Here's some data about the system we use:

• php 5.4.4
• mysqlserver 5.5.33

Tested this with php5-mysql and php5-mysqlnd, and it doesn't work with either of both.

[doctrinebot]

Issue was closed with resolution "Cannot Reproduce"

[gnat42]

I think we hit a bug this may be reporting, I've submitted a PR with a test showing the problem but not a fix in #9430