doctrine / phpcr-odm

Doctrine PHPCR ODM
http://www.doctrine-project.org/projects/phpcr-odm.html
MIT License
183 stars 97 forks source link

chore(composer): Allow PHPUnit 9 and Doctrine Instantiator 2 #844

Closed scyzoryck closed 1 year ago

scyzoryck commented 1 year ago

Hello!

schmittjoh/serializer are requiring as a dev dependency this package. To run all tests with doctrine/instantiator in version 2, we need to also allow this dependency here. It looks like there is no backward incompatibilities between them - test passed on my local env with jackrabbit. I also needed to bump PHPUnit to 9.x - in that version it produces some deprecation notices but it looks like the replacement method will be added in PHP 10.1. As example:

assertObjectHasAttribute() is deprecated and will be removed in PHPUnit 10. Refactor your test to use assertObjectHasProperty() (PHPUnit 10.1.0+) instead.

Best, scyzoryck.