documentationjs / documentation

:book: documentation for modern JavaScript
http://documentation.js.org/
Other
5.78k stars 482 forks source link

14.0.2 CLI --project-name and --project-version parameters not priority over package.json #1615

Open visionmax opened 9 months ago

visionmax commented 9 months ago

I've been using DocumentationJS for years now. Just updated client to 14.0.2 on Windows, and seems like command line parameters for client such as:

are no longer a priority over values stored in package.json.

Command line I use:

documentation --project-name "Project name" --project-version "0.1.601" --project-homepage "https://www.something.com/" build "../src/**/*.js" -f html -o "../docs-v0.1-stable/"`

Generated documentation is in html, and all content is correctly parsed, except it uses project name and version from package.json rather than from the command line.

I've seen that this issue is supposed to be fixed for 14.0.1, as there was a fix merged, however I've just installed fresh 14.0.2 and still experience the same issue.

If I remove project name and version from package.json, then generated documentation has no project name.

Am I doing something wrong here?

Added:

I just tried to rename package.json into something else, and command line parameters are used as expected. However as soon as package.json is present, command line parameters are ignored.

mlafeldt commented 3 months ago

Same here. I can confirm that package.json always takes precedence - even if name isn't set, in which case the project name will be empty.