search

documentcloud / document-viewer

The NYTimes Document Viewer
http://open.blogs.nytimes.com/2010/03/27/a-new-view-introducing-doc-viewer-2-0/
Apache License 2.0
691 stars 120 forks source link

mini is not defined #14

Open fodaley opened 12 years ago

fodaley commented 12 years ago

Hello, I just downloaded the code and ran it as is. I get a "mini is not defined" error in firebug. When I replace the viewer.js with the one on the live documentcloud site, the error is gone and everything works fine. Is the code on here the latest code?

When I do a diff of viewer.js I do see differences. Thanks.

knowtheory commented 12 years ago

Hey @Fodaley, yes, this is the code base we deploy out of.

Just to be clear, you're seeing the error when you open this? https://github.com/documentcloud/document-viewer/blob/master/viewer-debug.html

fodaley commented 12 years ago

Hi Ted, Thanks for your response. Just to clarify, here's a way to reproduce the error. I just downloaded the viewer as a zip file and extracted it.

If I open viewer.html, nothing loads and there is an issue with viewer.js.

If I open viewer-debug.html then the viewer loads with the Torrance crime map document.

Since the viewer-debug.html works then I guess all the javascript files are fine but viewer.js was not updated? I'm not sure.

On Sat, Apr 21, 2012 at 6:00 PM, Ted Han reply@reply.github.com wrote:

Hey @Fodaley, yes, this is the code base we deploy out of.

Just to be clear, you're seeing the error when you open this? https://github.com/documentcloud/document-viewer/blob/master/viewer-debug.html

Reply to this email directly or view it on GitHub: https://github.com/documentcloud/document-viewer/issues/14#issuecomment-5263955

knowtheory commented 12 years ago

Oh, you're absolutely right. Thanks for pointing that out.