Closed knowtheory closed 9 years ago
I've built a test for this into the horribly janky test page in this commit: https://github.com/documentcloud/documentcloud-notes/commit/06640d69eb8f171c1684161599587c36af5a12f6
And implemented the fix by just inlining the styles in this commit: https://github.com/documentcloud/documentcloud-notes/commit/b61c4e35e87d85dab9356b47452328212724229e
Also credit where credit is due:
Thanks to @JoeGermuska for reporting the issue after seeing it on http://www.propublica.org/article/nsa-documents-suggest-close-relationship-between-nsa-us-companies
Thanks dude!
One of the consequences of writing things into someone else's DOM is sharing their CSS rules.
We need our note images to have a
max-width
andmax-height
set tonone
or else our width and positioning calculations end up coming out wrong.Due to selector specificity (a page may use an ID on an element, and note embeds can't use IDs to override their specificity), i suspect we don't have any choice except to inline those directives.