Generating undefined host names for pixel ping urls

documentcloud / documentcloud-pages

Responsively embed DocumentCloud pages.

https://documentcloud.github.io/documentcloud-pages/examples/

MIT License

23 stars 10 forks source link

Generating undefined host names for pixel ping urls #34

Closed knowtheory closed 8 years ago

knowtheory commented 8 years ago

Reading from all of the analytics we have recorded thus far, we appear to be recording hosts such as http://pages.dcloud.org/examples as undefined/examples in some instances.

reefdog commented 8 years ago

Pretty sure the culprit is window.location.origin. Need to replace with the proper combination of IE-safe window.location properties.

reefdog commented 8 years ago

Forgot to tag this issue in 2bece30cff88ac89628d5c4ca0dfbf4d45b2fe87.