search

documentcloud / documentcloud-pages

Responsively embed DocumentCloud pages.
https://documentcloud.github.io/documentcloud-pages/examples/
MIT License
22 stars 10 forks source link

Should "View document" link to the `published_url`? #52

Closed ivarvong closed 8 years ago

ivarvong commented 8 years ago

Currently, the "View document" link points to the permalink for the doc. I expected it to link to our published_url, rather than the DC-hosted document.

I think this mean changing this getter but I have only poked around the code enough to be dangerous.

Thoughts?

reefdog commented 8 years ago

Short term, I should definitely be using published_url because that matches the precedent of note embeds and the expectations of existing users like you folks.

Longer term, we'd like to make this configurable so that we can still support orgs like y'all who have excellent home versions of the viewer, while not confusing our other users who are surprised by this behavior and its sometimes finicky results.

I'll have this patched today…

tommeagher commented 8 years ago

:clap: :clap: :clap:

reefdog commented 8 years ago

@tommeagher Thanks! It'll be rolled to production in just a couple minutes.

reefdog commented 8 years ago

Rolled out a few minutes ago. If you don't see it, refresh that cache away.

tommeagher commented 8 years ago

@ivarvong can confirm, but this appears to be working on our site now.

ivarvong commented 8 years ago

Thanks, @reefdog, looks great. (If you're wondering, here's what it looks like in the wild.)