Open knowtheory opened 7 years ago
Provide mechanism to detect whether a page is being iframed (so as to hide the banner)
This already happens. Two mechanisms hide the header on iframed note/page show pages:
?embed=true
is on the URL (which is what we set the iframe src to when we vend iframe embed codes), you get served a special templateIn both those cases, the <html>
tag gets a DC-embed-iframed
class, which hides the header and footer.
Edit: Actually, that second case only applies to pages, because the static note page doesn't even load the note embed JS; it's truly static. I can and should add it though, since I'm already checking if the page is being iframed for the sake of pixel ping.
In order to achieve the goal of better connecting source material to articles (INSERT LINK TO MANIFESTO HERE), we need a landing place on document pages hosted on documentcloud.org to link back.
The goal here is to funnel as much conversation & traffic back to the original sources.
Having discussed with @reefdog, the way we'll probably roll is a new banner header for documents/notes/pages, and to populate it with the manually set "remote_url" if available.†
That'll work as a first step towards pushing folks set
remote_url
, and soon to ask organizations to whitelist their domains, so we can employdetected_remote_url
in a saner way.So.
†: the
published_url
and thedetected_remote_url
is too noisy/messy at the moment, although i have moves we can make to clean that up especially by blacklisting certain domains when thedetected_remote_url
is calculated.