documentcloud / jammit

Industrial Strength Asset Packaging for Rails
http://documentcloud.github.com/jammit/
MIT License
1.16k stars 197 forks source link

CSS Media Queries issues with Yui Compressor < 0.9.3 #117

Closed dam5s closed 13 years ago

dam5s commented 13 years ago

The dependency with yui-compressor should be updated to >= 0.9.3 or ~> 0.9.3 Previous versions use an older version of YUI Compressor.

https://github.com/sstephenson/ruby-yui-compressor/issues/closed#issue/7

Cheers, Damien.

jashkenas commented 13 years ago

Thanks for the note. I've updated the gem dependency to be >= 0.9.3 at SHA: 5ad7c6a97a4e9cd8315a3d4669aa062ce3ed4979

volkanunsal commented 13 years ago

Has there been a regression? I'm using the correct versions of jammit and yui-compressor gem and still the media queries are not compressed correctly.

jammit (0.6.3)
  yui-compressor (>= 0.9.3)
dam5s commented 13 years ago

Jammit doesn't have a bug, an old version of Yahoo's YUI compressor had, which is used by the yui-compressor gem, itself used by Jammit.

So if you have bugs, you probably want to look at the version of YUI compressor used in the yui-compressor gem instead.