Soft dependencies on closure and uglify and yui as default.

documentcloud / jammit

Industrial Strength Asset Packaging for Rails

http://documentcloud.github.com/jammit/

MIT License

1.16k stars 197 forks source link

Soft dependencies on closure and uglify and yui as default. #154

Closed juggy closed 13 years ago

juggy commented 13 years ago

Based on issue https://github.com/documentcloud/jammit/issues/closed/#issue/123/comment/916842

This provides a more flexible approach. You can chose your compressor and not install any other.

jashkenas commented 13 years ago

Thanks, this is merged to master at 50a85d0fc06be5d9f7a3484179ef1a14908b6ad8.

yfeldblum commented 13 years ago

Any reason this has a hard dependency on YUI?

The ideal approach would be to remove the hard dependency on YUI. Jammit could print out a warning message if it can't find any compressors (with an option to turn that off, e.g. in an initializer, if you really don't want any compressors).

Cheers!

juggy commented 13 years ago

My idea was to make it an easy install... Just include the gem and you are set. Putting no compressors would require changes in the config of people using the defaults.

jashkenas commented 13 years ago

Yes -- YUI is currently always needed in order to compress CSS, so it seems like a good baseline. If we find good pure Ruby compressors for both CSS and JS, we can remove all the Java dependencies ... but I don't think the quality would be nearly as high.