search

documentcloud / jammit

Industrial Strength Asset Packaging for Rails
http://documentcloud.github.com/jammit/
MIT License
1.16k stars 197 forks source link

ruby-yui-compressor 0.9.5 breaks jammit 0.5.1 #155

Closed chubas closed 13 years ago

chubas commented 13 years ago

They updated today ruby-yui-compressor to 0.9.5, and when updated, running jammit just hangs. We solved it by explicitely adding yui-compressor 0.9.1 to our Gemfile.

Not sure what other versions of jammit are affected. Just posting in case some other people experiences the same problem

hennk commented 13 years ago

I have the same problem with jammit 0.6.0. Forcing yui-compressor to 0.9.4 fixed it. I just had time for a quick look at the last commit of yui-compressor, https://github.com/sstephenson/ruby-yui-compressor/commit/e24acb30b931eb26e723808c9ee1fc8e5e04dc00, mentioning raising an exception if compression fails due to js errors. Maybe the problem is, that jammit does not expect this exception?

jsl commented 13 years ago

FYI, I've raised this issue at the ruby-yui-compressor project: https://github.com/sstephenson/ruby-yui-compressor/issues/12.

jashkenas commented 13 years ago

Looks like this is a ruby-yui-compressor issue that has since been fixed.