documentcloud / jammit

Industrial Strength Asset Packaging for Rails
http://documentcloud.github.com/jammit/
MIT License
1.16k stars 197 forks source link

Fix implicit string conversion of Pathname #260

Closed whitethunder closed 10 years ago

whitethunder commented 10 years ago

In Rails 3, Rails.public_path returns a String, but in Rails 4 it returns a Pathname. This breaks on the implicit conversion to String here: https://github.com/documentcloud/jammit/blob/master/lib/jammit/packager.rb#L113

If we explicitly instantiate DEFAULT_PUBLIC_ROOT as a String instead of a Pathname (as would happen in Rails 3 and earlier), the problem is solved.