search

documentcloud / underscore-contrib

The brass buckles on Underscore's utility belt
MIT License
621 stars 117 forks source link

Note cloning of obj in setPath & updatePath #164

Closed seidtgeist closed 10 years ago

seidtgeist commented 10 years ago

In response to https://twitter.com/joshuacc/status/494566618605694976 /cc @joshuacc

I checked CONTRIBUTING.md but I'm confused where to add the docs.

Should they be added here instead? Where are the examples coming from?

joshuacc commented 10 years ago

@ehd Thanks! Yeah, documentation updates should be done in the markdown files. I'll add a note to CONTRIBUTING.md about that.

joshuacc commented 10 years ago

@ehd To clarify, your documentation update should be done here: https://github.com/documentcloud/underscore-contrib/blob/master/docs/underscore.object.builders.js.md

seidtgeist commented 10 years ago

Ok, then the commits I already made happened in the right place?

joshuacc commented 10 years ago

@ehd Yep. Looks good to me!

joshuacc commented 10 years ago

Thanks @ehd !

seidtgeist commented 10 years ago

Thank you :wink: