search

documentcloud / underscore-contrib

The brass buckles on Underscore's utility belt
MIT License
621 stars 117 forks source link

_.partitionBy docs show _.keep instead #211

Closed lucaslin closed 4 years ago

lucaslin commented 8 years ago

The docs for partitionBy show the signature as _.keep(array:Array, fun:Function).

Maybe it just needs to be rebuilt?

The current .md docs show the correct signature.

https://github.com/documentcloud/underscore-contrib/blob/master/index.html#L304

http://documentcloud.github.io/underscore-contrib/#partitionby

jgonggrijp commented 4 years ago

I was able to confirm that it just needs to be rebuilt. @joshuacc Do we build the docs only on release? In that case we can close this.

joshuacc commented 4 years ago

@jgonggrijp Yes, that is the current practice. Ideally I'd like to pull the built docs out of git entirely to avoid this sort of misunderstanding.