Add support to newer jquery versions

documentcloud / visualsearch

A Rich Search Box for Real Data

http://documentcloud.github.io/visualsearch/

MIT License

1.8k stars 225 forks source link

Add support to newer jquery versions #86

Closed blittle closed 11 years ago

blittle commented 11 years ago

This is an attempt to fix compatibility issues with the newer versions of jquery in issue #85.

blittle commented 11 years ago

This should probably be changed from:

if (autoCompleteData['value'] == box.val()) {
  //box.data('autocomplete').menu.activate(new $.Event("mouseover"), $value);
}

to:

if (autoCompleteData['value'] == box.val() && box.data('autocomplete').menu.activate) {
  box.data('autocomplete').menu.activate(new $.Event("mouseover"), $value);
}

fdaugan commented 11 years ago

This patch works for me (1.9.2). Thanks a lot.

flipdoubt commented 11 years ago

Is this available to download somewhere? I followed the links to the blittle repository but could not find a branch where the jQuery file names changed. I still don't get git and don't trust my understanding to apply the patch and produce something that should work.

blittle commented 11 years ago

If you look in my fork, the built js files are updated to support jQuery 1.9 although the actual dependencies.js file still is jQuery 1.6.1.

Download visualsearch.js and visualsearch.css at https://github.com/blittle/visualsearch/tree/master/build

flipdoubt commented 11 years ago

That does work for us. Thank you very much.

mattbrun commented 11 years ago

Just found your patch after resolving the _renderItemData() bug by myself... Anyway, thanks a lot for your work. Your pull request works like a charm for me with jQuery 1.8.3 and jQuery UI 1.9.2 :)

tomaswitek commented 11 years ago

Hi, the patch works fine with new jquery version, but witch older one I am getting this error: Uncaught TypeError: Object #