search

documentcloud / wordpress-documentcloud

Embed DocumentCloud documents that won't be eaten by the visual editor
https://wordpress.org/plugins/documentcloud/
GNU General Public License v2.0
9 stars 14 forks source link

Add responsive options to shortcode #14

Closed eyeseast closed 9 years ago

eyeseast commented 9 years ago

Now that @documentcloud is moving towards a responsive viewer (https://github.com/documentcloud/document-viewer/pull/46) we should add the options to the shortcode. Question is, should embeds be responsive by default?

reefdog commented 9 years ago

+1 to the option being added, but it's not ready yet to be the default.

reefdog commented 9 years ago

Offline consensus is that we can indeed default to responsive. Making it so.

eyeseast commented 9 years ago

Seems reasonable to me, too.

On Tue, Apr 28, 2015 at 2:48 PM, Justin Reese notifications@github.com wrote:

Offline consensus is that we can indeed default to responsive. Making it so.

— Reply to this email directly or view it on GitHub https://github.com/documentcloud/wordpress-documentcloud/issues/14#issuecomment-97167920 .

Chris Amico Glass Eye Media LLC http://glasseyemedia.org

reefdog commented 9 years ago

I just realized this means width/maxwidth effectively have no impact unless you set responsive:false. Guess we should document that.