Explicitly check for things with `isset()`

documentcloud / wordpress-documentcloud

Embed DocumentCloud documents that won't be eaten by the visual editor

https://wordpress.org/plugins/documentcloud/

GNU General Public License v2.0

9 stars 14 forks source link

Explicitly check for things with `isset()` #27

Closed reefdog closed 8 years ago

reefdog commented 9 years ago

See: https://wordpress.org/support/topic/error-if-note_id-not-in-url

My guess is that stricter error reporting levels freak out when trying to access a non-existent object attribute, even when part of a conditional intended to check that very thing.

reefdog commented 9 years ago

Confirmed: when error reporting is set to show notices, accessing non-existent array keys displays an error.

reefdog commented 9 years ago

1f6b791658723d9b7b65536956ad29a949295ea5

reefdog commented 8 years ago

ac2b5133c306c4f2f25b72e9e6ecc9d3d05b8161