search

documentcloud / wordpress-documentcloud

Embed DocumentCloud documents that won't be eaten by the visual editor
https://wordpress.org/plugins/documentcloud/
GNU General Public License v2.0
9 stars 14 forks source link

Add to WordPress VIP shared plugins repository #30

Closed bcampeau closed 8 years ago

bcampeau commented 8 years ago

One of our clients is interested in using your plugin on WordPress VIP. I see some minor code formatting and minor issues to resolve so it would pass their code review process. Would you be open to a pull request for this before we invest the effort? We can also help get this into the review queue for WordPress VIP since we're a partner.

Your plugin would then also be available to all WordPress VIP sites, which include some of the largest publishers in the world: https://vip.wordpress.com/plugins/

Let me know your thoughts on this. Thanks.

knowtheory commented 8 years ago

:100:% interested and happy to work with you on this. cc/ @reefdog

Our intent has been to treat our wordpress plugin as a primary target for future feature development w/r/t our externally facing APIs. So, at the very least we'd love to chat more about the ongoing expectations set by the VIP review process with someone who has experience with it!

bcampeau commented 8 years ago

There is no real expectation other than to continue to support the plugin as needed, which is as often or little as you like. Every line of code on VIP is shared with all of WordPress.com, so there is a pretty stringent code review process for new plugins.

We've been through it many times, so I figured it would be easier to start with a pull request of my suggestions. We can help get it into their repository since you're not currently a partner. Expect to see something in the next week or so and we can go from there.

reefdog commented 8 years ago

:+1: Thanks @bcampeau!

bcampeau commented 8 years ago

Just wanted to let you know this has finally been sent your way in https://github.com/documentcloud/wordpress-documentcloud/pull/32.

Thanks.

reefdog commented 8 years ago

This is terrific, @bcampeau, thanks! I'll take a look at it this week. We really appreciate your work on this.

reefdog commented 8 years ago

@bcampeau When you reach out to the VIP folks, have them contact us at support@documentcloud.org if they want to get a DocumentCloud account for testing this. Although they can also experiment with generating shortcodes and embedding raw URLs for any public document, like https://www.documentcloud.org/documents/282753-lefler-thesis.html

reefdog commented 8 years ago

:arrow_up: That's obviously meant for after I actually tag and release your edits, hah. Should be this week, just want to fix a couple bugs I found (unrelated to your changes).

reefdog commented 8 years ago

One question, @bcampeau: I noticed you converted soft tabs (spaces) to tabs. That doesn't seem to be a WP VIP requirement. Is that just a stylistic preference, or is there a VIP reason to keep them tabs?

bcampeau commented 8 years ago

It's WordPress coding standards, not VIP. However, they do make the code more readable and is their preferred format as well.

reefdog commented 8 years ago

Got it. We'll conform, then. Thanks!

reefdog commented 8 years ago

Tagged and deployed.

bcampeau commented 8 years ago

Great, thanks.

On Thu, Feb 25, 2016 at 6:35 PM, Justin Reese notifications@github.com wrote:

Tagged and deployed.

— Reply to this email directly or view it on GitHub https://github.com/documentcloud/wordpress-documentcloud/issues/30#issuecomment-189035226 .

Brad Campeau-Laurion Partner, Alley Interactive 212-257-2154

bcampeau commented 8 years ago

@reefdog VIP asked for a couple minor changes, which I've handled in #41 if you can review and merge.

Thanks.

reefdog commented 8 years ago

Merged in, thanks @bcampeau. Presumably I need to actually release a new version to get the VIP team to re-evaluate? Bit of a bummer, since it'll prompt people to upgrade, but seems worthwhile.

bcampeau commented 8 years ago

I'll just notify them the changes have been merged and they'll just pull the latest from the master branch.

reefdog commented 8 years ago

Oh, excellent, thanks @bcampeau!

bcampeau commented 8 years ago

There's been a bit of a swerve here at the last minute. VIP is not accepting any new plugins to the shared plugins repository. Going forward, they're going to keep an approved plugins list and the latest version that has been reviewed. Clients that wish to use these plugins can commit them directly to their own repository.

Therefore, you can advise anyone on VIP that wishes to use this plugin they may include it and it will not incur any additional code review. They should be formalizing and publicizing this list and the new procedure in the coming weeks.

reefdog commented 8 years ago

So it's moving from an enforced whitelist to a "verified" badge, basically?

Thanks for spearheading this regardless, @bcampeau. The plugin is better for it.

bcampeau commented 8 years ago

I'm not really sure how this will work logistically, but something like that.

knowtheory commented 8 years ago

@bcampeau btw, with your end goal of getting your client up and running with our plugin... is there anything we can do to help you on that front, or are you effectively stymied until WP.com comes out with their new process?

bcampeau commented 8 years ago

No holdup. The plugin is live on their site via the method I described - including it in the theme.