search

documentcloud / wordpress-documentcloud

Embed DocumentCloud documents that won't be eaten by the visual editor
https://wordpress.org/plugins/documentcloud/
GNU General Public License v2.0
9 stars 14 forks source link

Allow default setting to show/hide sidebar #31

Open eyeseast opened 8 years ago

eyeseast commented 8 years ago

The plugin allows defaults for size, but the sidebar is another frequently used setting. (I always turn it off in posts, for example.)

Any other knobs and dials that should be default-able?

reefdog commented 8 years ago

Arguably, all booleans could be. Here's the list of accepted ones:

https://github.com/documentcloud/wordpress-documentcloud/blob/9f682529eef5aff13350b8990ac7b52e4d14ec09/documentcloud.php#L145-L168

eyeseast commented 8 years ago

I think it makes sense to include all of them. Might as well make this easy for people.

reefdog commented 8 years ago

:+1: You wanna take a crack at it?

I don't much care what the defaults for text/pdf/sidebar are (I just left the existing defaults in), but responsive should default true.

eyeseast commented 8 years ago

Yeah, can do. I was also going to take a shot at #25 this week or next.

reefdog commented 8 years ago

Awesome! I'm about to tag and release v0.4.1 with the VIP conformity and #35. #25 would justify a v0.5.0 release, IMO.