search

documentcloud / wordpress-documentcloud

Embed DocumentCloud documents that won't be eaten by the visual editor
https://wordpress.org/plugins/documentcloud/
GNU General Public License v2.0
9 stars 14 forks source link

Fix PHP code style errors, per PHPCS #39

Closed paulschreiber closed 8 years ago

paulschreiber commented 8 years ago

Fixes whitespaces error and adds strict equality checks.

phpcs -p -s -v --colors --standard=WordPress-VIP documentcloud.php

reefdog commented 8 years ago

@paulschreiber Good idea, running this through phpcs. @bcampeau is currently helping us get approved for WordPress VIP (#30), and I just merged in some requested feedback from the VIP team (#41), which conflicts with your 2adb1e0. Can you resolve and resubmit? And while doing so, can you separate the TinyMCE work into a separate PR? I'd like to evalulate them separately. Thanks!

bcampeau commented 8 years ago

I'd like to proceed with the existing VIP review as-is and then push this as the next version, if that's OK.

reefdog commented 8 years ago

@bcampeau I think that's sensible, considering the VIP team is already mid-review. On that note, how do they handle future releases? Do they evaluate each one?

bcampeau commented 8 years ago

Any time you want to push a new version to VIP, you have to open a ticket and request a review.

paulschreiber commented 8 years ago

I'll close this PR and make a new PHPCS-only PR.