search

docusealco / docuseal

Open source DocuSign alternative. Create, fill, and sign digital documents ✍️
https://www.docuseal.co
GNU Affero General Public License v3.0
6.26k stars 446 forks source link

SMTP error when saving email settings #142

Closed alexismdr closed 10 months ago

alexismdr commented 10 months ago

When I save email settings, the following error is displayed:

553-5.1.7 The sender address is not a valid RFC 5321 address. Please [...]

Without this commit, everything works normally. I think the variable "message.from" is the sending email and not "{Name} <{Email}>"

omohokcoj commented 10 months ago

@alexismdr could you please provide your company name specified in /settings/account ?

alexismdr commented 10 months ago

@omohokcoj "Fluxs, Productions Audiovisuelles"

omohokcoj commented 10 months ago

@alexismdr comma ", " in the company name breaks emails sending - removing comma should fix the issue

alexismdr commented 10 months ago

@omohokcoj Ok, thanks for your help. It would still be good to fix the problem as we don't have this problem with other mail clients.

omohokcoj commented 10 months ago

@alexismdr yeah looks like the way how we generate a friendly email name could have been improved https://github.com/docusealco/docuseal/commit/3c69430b947c1c1ea61e25ad9275b14df005a3c7 a fix to include commas will be available in the next release. Thanks for reporting the issue!