docusealco / docuseal

Open source DocuSign alternative. Create, fill, and sign digital documents ✍️
https://www.docuseal.co
GNU Affero General Public License v3.0
6.23k stars 443 forks source link

SMS is verified multiple times #251

Closed estallio closed 5 months ago

estallio commented 5 months ago

Hi!

I played around with SMS verification. In my document, the SMS-field was somewhere in the middle. First, I filled out some other fields like name etc. Then I filled out the phone-field and verified my number. Next, I followed the filling process with the next-button and filled out the missing fields. At the end, I got redirected to the phone-field again which got cleared. Then I had to fill out and verify my number again to finish the signing process. In the audit-logs the SMS-verification step is also listed two times. Does this mean the phone-field has to be always the last one? Or can you somehow check if the SMS-verification has already been submitted before requesting it again?

Cheers, Leo

omohokcoj commented 5 months ago

@estallio thanks for pointing this out - in the latest version we made it so that the phone field can be verified only once

estallio commented 5 months ago

Now, the SMS is skipped. My case: I have a web form. The user fills out the form and submits the date. I check the data and correct them. Afterwards, I send a link to the user that opens my website where a DocuSeal form is embedded. All fields are prefilled with the react component. All fields are read-only, except the phone field. The user can now click on signature and submit the form, without getting asked for the SMS. However, when manually selecting the phone-field and clicking on "Next", the number gets verified. The expected behavior is that the pre-filled phone number has to be verified and can not be skipped.

omohokcoj commented 5 months ago

@estallio thanks for reporting this - the issue has been fixed in the docuseal cloud, please let me know if everything works as expected.

estallio commented 5 months ago

Thank you for the quick fix. The form now jumps back to the phone number field. However, now the pre-fill of the phone number does not work as expected. The red bar in the PDF id empty but the pre-filled phone number is visible in the form field at the bottom. Additionally, I can not edit the number in the form field at the bottom and when I click on the red bar in the PDF, there is an error in the JS console. image

omohokcoj commented 5 months ago

@estallio the 422 is an expected error that is returned to let the front-end know that the phone is not verified yet. That's true that with prefilled phone number it's not possible to edit it - does your use case require editing a phone number?

estallio commented 5 months ago

No, that is not the use case, but the form looks like this, which might be confusing: image

As you can see, the phone number in the red bar is missing, but is visible in the modal. When I click next, the phone number also appears in in the red bar in the PDF view.

omohokcoj commented 5 months ago

@estallio phone number appears in the box only after it was verified via the OTP

estallio commented 5 months ago

Ah I see. Thanks for the clarification and the fast response times - I appreciate your service!