docusealco / docuseal

Open source DocuSign alternative. Create, fill, and sign digital documents ✍️
https://www.docuseal.co
GNU Affero General Public License v3.0
5.55k stars 369 forks source link

remove github stars badge or allow header customization #302

Closed meonkeys closed 6 days ago

meonkeys commented 6 days ago

DocuSeal is amazing. Easy to install, fast, clean, works well. Thank you!

Are the current maintainers open to the idea of removing the GitHub badge? I'd rather my self-hosted DocuSeal does not reach out from my server to ping a 3rd party website on every page hit (yeah, I know some of these are cache hits). I think other DocuSeal self-hosters might prefer this as well (please thumbs up/down this issue to indicate support/dissent for the idea). Alternatively, maybe we allow customization of the header since some folks might want to rebrand / OEM / white label DocuSeal.

omohokcoj commented 6 days ago

Hi @meonkeys thanks for the feedback. white label is the part of DocuSeal Pro self-hosted: https://www.docuseal.co/pricing We're not planning to make branding/whitelabel in the free open-source version of the app.

meonkeys commented 6 days ago

Understood. How about just removing the badge? I'm concerned it may be used to "phone home" (apologies if that isn't the intent of the GH stars badge -- I'd appreciate a clarification here). Would you consider a pull request to either remove the GH badge or allow customizing the header? I might give that a shot myself if you'd consider my PR.

omohokcoj commented 6 days ago

@meonkeys customizations to the header/logo and GH badge removal is already available in Pro

meonkeys commented 6 days ago

Indeed, thanks, I saw you mentioned that above. Sounds like the answers are "no" to my original issue and "no" to a PR that did either, since these are part of the Pro product. Let me know if I got that wrong. I'll close this. Thanks for all your replies, @omohokcoj

meonkeys commented 6 days ago

Related: #143

sistein commented 6 days ago

I would also prefer to have the GitHub call removed... Especially if it is this useless.