docusealco / docuseal

Open source DocuSign alternative. Create, fill, and sign digital documents ✍️
https://www.docuseal.co
GNU Affero General Public License v3.0
5.97k stars 410 forks source link

Health check endpoint is missing #96

Closed Bhautik0110 closed 8 months ago

Bhautik0110 commented 1 year ago

Issue

AlexandrToorchyn commented 1 year ago

@Bhautik0110 We're waiting for rails 7.1 which has this feature out of the box: https://github.com/rails/rails/pull/46936

For now you can just use / path for healthcheck

Bhautik0110 commented 1 year ago

@AlexandrToorchyn I am new to ruby, Does rails 7.1 version mention health point checks db health status as well? Because it mentioned

Reveal health status on /up that returns 200 if the app boots with no exceptions, otherwise 500.

AlexandrToorchyn commented 1 year ago

@Bhautik0110 Rails default healthchecker doesn't include the DB healthcheck

Bhautik0110 commented 1 year ago

@AlexandrToorchyn If we can add the db health check, it is good when the server is unable to connect to DB (sometime we call it as readiness probe). While the default health check endpoint is used for server liveness check.

BeshoyAtef commented 8 months ago

used this , works fine

healthcheck: test: ["CMD-SHELL", "netstat -an | grep 3000 > /dev/null; if [ 0 != $? ]; then exit 1; fi;"] interval: 60s retries: 100 start_period: 20s timeout: 10s

omohokcoj commented 8 months ago

@BeshoyAtef /up healthcheck endpoint has been added in the 1.3.6 release