search

docusign / docusign-esign-csharp-client

The Official Docusign C# Client Library used to interact with the eSignature REST API. Send, sign, and approve documents using this client.
https://developers.docusign.com/docs/esign-rest-api/sdks/csharp/
MIT License
129 stars 159 forks source link

Fix setting BasePath and OAuthBasePath in DocuSignClient ctors #388

Closed gagyn closed 1 year ago

gagyn commented 1 year ago

_I lost 2 hours investigating why I'm getting USER_AUTHENTICATION_FAILED response. It was happening, because SDK was calling production API, instead of demo, even after providing BaseUrl for Demo to DocuSignClient constructor. 😐_

Current version of DocuSign SDK contains bug causing wrong assignment of BasePath while initializing DocuSignClient object. Current workaround is to set api base path using SetBasePath(basePath), but it should be done by constructor, when using overload: public DocuSignClient(string apiBase, string oAuthBase, IWebProxy proxy = null) (line 155).

Also Configuration = new Configuration(apiBase); is useless in every constructor as SetBasePath method always calls it anyway but haven't touched it.

AppVeyorBot commented 1 year ago

AppVeyor build and test pass.

voltaek commented 1 year ago

It would appear that these changes were made as part of v6.1.0. See here in the commit.

kenharris commented 1 year ago

Correct, these changes have been incorporated into a recent release. Closing the PR.