Sane ApiClient (concurrency/resource usage improvements)

sabirove commented 3 years ago

This PR aims to solve/provide a workaround for

ApiClient concurrency issues (e.g: https://github.com/docusign/docusign-esign-java-client/issues/123)
Inefficient resource utilization issues (e.g. new http Client and ObjectMapper allocated per each new client with no way to provide those from the outside, thus avoiding concurrency issues by creating new instance is not an option. On top of that new http Client is allocated per each method call (!!!) for certain methods, see ApiClient::buildHttpClient).

Note:

Changes are not braking and backwards compatible
ApiClient API is intact. New API (ApiClientFactory) is added to address the issues
Java version bumped to 1.8 (README.MD specifies requirement as 1.9+ anyway)

sabirove commented 3 years ago

@mmallis87 please take a look.

sabirove commented 3 years ago

Build fails with

SdkUnitTests.setUp:68->getLastTenEnvelopeIds:1825 Exception: rsaPrivateKey byte array is empty

because this statement in SkdUnitTests

private static final byte[] privateKeyBytes = Base64.decode(System.getenv("PRIVATE_KEY"));

yields empty byte array. Not sure this has something to do with PR changes, looks more like a CI/env config related issue.

docusign / docusign-esign-java-client