Closed sabirove closed 2 years ago
@mmallis87 please take a look.
Build fails with
SdkUnitTests.setUp:68->getLastTenEnvelopeIds:1825 Exception: rsaPrivateKey byte array is empty
because this statement in SkdUnitTests
private static final byte[] privateKeyBytes = Base64.decode(System.getenv("PRIVATE_KEY"));
yields empty byte array. Not sure this has something to do with PR changes, looks more like a CI/env config related issue.
https://app.travis-ci.com/github/docusign/docusign-esign-java-client/jobs/529199291
This PR aims to solve/provide a workaround for
ApiClient
concurrency issues (e.g: https://github.com/docusign/docusign-esign-java-client/issues/123)Client
andObjectMapper
allocated per each new client with no way to provide those from the outside, thus avoiding concurrency issues by creating new instance is not an option. On top of that new httpClient
is allocated per each method call (!!!) for certain methods, seeApiClient::buildHttpClient
).Note:
ApiClient
API is intact. New API (ApiClientFactory
) is added to address the issues