Error is not returned when working with async/await or promise

docusign / docusign-esign-node-client

The Official DocuSign Node.js Client Library used to interact with the eSign REST API. Send, sign, and approve documents using this client.

http://docusign.github.io/docusign-esign-node-client

MIT License

146 stars 100 forks source link

Error is not returned when working with async/await or promise #336

Closed TristanDELMAS closed 2 months ago

TristanDELMAS commented 1 year ago

When the request is not accepted by docusign, the only returned thing is a bad request message with no information.

To fix it, ApiClient.js should be reject({...error, data }); on line 592 (if no callback and if error of callApi.

The same is true for sendJWTTokenRequest on line 109 that should be reject({ ...err, data });

sonawane-sanket commented 4 months ago

@TristanDELMAS We improved API responses (success & error formats) across all APIs. Upgrade to the latest SDK 7.0.1 for this benefit. Let us know if the issue persists after upgrading.