search

docusign / docusign-esign-php-client

The Official Docusign PHP Client Library used to interact with the eSign REST API. Send, sign, and approve documents using this client.
https://www.docusign.com/devcenter
MIT License
198 stars 123 forks source link

Brand ID in the wrong place #111

Closed dgoring closed 4 years ago

dgoring commented 4 years ago

if you go by this https://developers.docusign.com/esign-rest-api/code-examples/brands-sending-envelope

The brand id is assigned to the individual signer not the entire envelope.

the brand_id setters and getters need to been moved from the EnvelopeDefinition model to the Signer model.

LarryKlugerDS commented 4 years ago

A brand_id is assigned to the envelope definition, not to the signer object.

You've spotted a bug in the powershell and bash examples, thank you! The other examples correctly show the brand_id as part of the envelope definition.

I have filed internal ticket DEVDOCS-3130

Regards, Larry

dgoring commented 4 years ago

No I've tested this and it works when the brand_id is put as part Signer Model

It does nothing when you assign it to the envelope, the bash is correct to the API and the PHP is wrong

LarryKlugerDS commented 4 years ago

Hmmm, interesting. I will look into it further. I've re-opened the issue.

LarryKlugerDS commented 4 years ago

One of our engineers has tested this and his results show that the brandId is part of the envelope definition, not the signer definition. This is also confirmed by the Swagger file.

Additional attributes are ignored by DocuSign, so placing a brandId in the signer object will have no affect. Thanks, Larry