docusign / docusign-esign-php-client

The Official Docusign PHP Client Library used to interact with the eSign REST API. Send, sign, and approve documents using this client.
https://www.docusign.com/devcenter
MIT License
198 stars 122 forks source link

Not working on php 8+ #165

Closed Theo4 closed 2 years ago

Theo4 commented 2 years ago

Hello,

Trying to use the lib on a php8+ version and it doesn't work. A lot of deprecated notice and impossible to authenticate are main problems.

Is there any planned update ?

Thank you,

plezan commented 2 years ago

Hello, we also have have this deprecations notice :

Return type of DocuSign\eSign\Model\*** should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

on every Docusign model using offsets :

Do you think it's possible to use the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice while you get this issue fixed ?

Thanks

Edit :

after some research it looks like a PHPSwaggerGen issue that has been fixed in the last release : https://github.com/vanderlee/PHPSwaggerGen/blob/master/CHANGELOG.md#2321---2021-01-07

dbbrahmbhatt commented 2 years ago

Thank you for filing the issue. We are currently working on the fix for this. Update will be posted here once the fix is shipped.

dbbrahmbhatt commented 2 years ago

Issue has been fixed using #[\ReturnTypeWillChange] attribute in release 6.7.1