Consider making firebase/php-jwt version requirement more relaxed.

docusign / docusign-esign-php-client

The Official Docusign PHP Client Library used to interact with the eSign REST API. Send, sign, and approve documents using this client.

https://www.docusign.com/devcenter

MIT License

196 stars 123 forks source link

Closed nicosp closed 1 year ago

nicosp commented 2 years ago

Is it possible to change the dependency from : "firebase/php-jwt": "^5.0" to "firebase/php-jwt": "^5.0 || ^6.0" ?

The current strict dependency prevents us from updating.

Adrian-DS-Support commented 2 years ago

Thank you for your feedback.

We will pass it on to our engineering team, they will take this into consideration for our next release.

Our SDK is a good start, please feel free to make the necessary changes to the files.

bbeckford commented 2 years ago

We also require this dependency change, please 👍

ArthurGuy commented 1 year ago

Same here, it's blocking the installation of another package

wizhippo commented 1 year ago

Same here,

After reading the JWT 6.0 BC breaks and searching for them in the code here, non of them apply so it should be just a version bump without any issue.

apsylone commented 1 year ago

So long to wait for a minor fix like this... Still blocking on my side too ! @Adrian-DS-Support any news on this ticket opened 6 month ago ?

Thanks,

klimslim commented 1 year ago

firebase/php-jwt has a vulnerability CVE-2021-46743 that was fixed in 6.x only. This issue should definitely be fixed.

Dr-Shadow commented 1 year ago

This seems to be a blocking issue on our side as well.

We would like to add docusign as a new eSign provider in our application.

Any news from the SDK team about this ? @karankaushik95 @Adrian-DS-Support

dbbrahmbhatt commented 1 year ago

Hello All, Thank you for filing the issue. We have added the support for firebase/php-jwt 6.* in release 6.12.0-rc.