search

docusign / docusign-esign-php-client

The Official Docusign PHP Client Library used to interact with the eSign REST API. Send, sign, and approve documents using this client.
https://www.docusign.com/devcenter
MIT License
198 stars 124 forks source link

Fix PHP parse errors in AccountsApi #37

Closed aaronhuisinga closed 7 years ago

aaronhuisinga commented 7 years ago

Hey DocuSign team, I'm not sure how this one slipped through, but the entire AccountsApi is broken due to a parse error. I see your team used a generator to create the classes, and it seems there was something wrong that caused a comma to be missed in two of the class methods. This has broken the whole AccountsApi class.

I've gone ahead and fixed the methods, which fixes all Accounts related API calls. I'm assuming this will need to be fixed in your generator as well.

This is pretty high priority, as a large chunk of the API is completely broken in the 3.0.0 release.

aaronhuisinga commented 7 years ago

@gsnavin Please take a look at this and review it ASAP. Anyone that upgraded to v3.0.0 has a broken API.

gsnavin commented 7 years ago

@aaronhuisinga Thanks for reporting the issue, I am looking into this issue and will fix this ASAP.

aaronhuisinga commented 7 years ago

Thanks, @gsnavin!

aaronhuisinga commented 7 years ago

@gsnavin could you tag a new release as well so those of us using Composer can update?

gsnavin commented 7 years ago

Yes I am doing it now, should be available in a few.