search

docusign / docusign-esign-php-client

The Official Docusign PHP Client Library used to interact with the eSign REST API. Send, sign, and approve documents using this client.
https://www.docusign.com/devcenter
MIT License
198 stars 124 forks source link

v4.0.0 Incorrect ApiException exception references #78

Closed abarke closed 4 years ago

abarke commented 5 years ago

ApiException class was moved, however references/phpdocs throughout the code do not point to the new location.

e.g. \DocuSign\eSign\Client\ApiException is referenced in many places as \DocuSign\eSign\ApiException which my editor PHPStorm complains about it not existing.

I also noticed that the PHP code is not to PHP best practices in places. I would recommend using phpstan to scan the code: https://github.com/phpstan/phpstan

abarke commented 5 years ago

Here is the code analysis from PhpStorm:

The Php Inspections (EA Extended) PhpStorm Plugin has some extra in-editor inspections that are very useful.

I suggest a serious tidyup is needed. This is not production ready code in my eyes.

image

image

LarryKlugerDS commented 5 years ago

Thank you for the bug report. I have filed internal bug DCM-3372

Re: I also noticed that the PHP code is not to PHP best practices in places. I would recommend using phpstan to scan the code: https://github.com/phpstan/phpstan

I have filed enhancement request DCM-3373

LarryKlugerDS commented 4 years ago

Hi @abarke , DocuSign engineering reports that this problem has been solved. Can you verify? Many thanks, Larry

abarke commented 4 years ago

Confirmed. Working with v5.0.0 and I dont see these errors anymore. Thanks.

LarryKlugerDS commented 4 years ago

Excellent, thank you