search

docusign / docusign-esign-python-client

The Official DocuSign Python Client Library used to interact with the eSign REST API. Send, sign, and approve documents using this client. https://www.docusign.com/devcenter
MIT License
97 stars 88 forks source link

Read proxy url from environment #148

Open nschenkels opened 2 years ago

nschenkels commented 2 years ago

These changes check if HTTPS_PROXY or HTTP_PROXY are set in the environment (in this order).

If so, the RESTClientObject class creates its pool_manager using urllib3.ProxyManager() instead of urllib3.PoolManager() and passes the proxy url taken from the environment variable.

jglassenberg commented 2 years ago

We're going to need some time to evaluate this code change. I can't provide an ETA, but it is on our list to review as we continue to update our SDKs.