Open mondaini opened 1 year ago
@mondaini We started to support versions greater than pyjwt>2
, hence in requirements file the restrictions is removed requirements.txt. You can manually also install the greater version and will work without issues.
Thanks for reaching out. -Harsha
@harsharahul
Thanks for your response.
setup.py
has a different constraint, though:
REQUIRES = ["urllib3 >= 1.15", "six >= 1.8.0", "certifi >= 14.05.14", "python-dateutil >= 2.5.3", "setuptools >= 21.0.0", "PyJWT>=1.7.1,<2", "cryptography>=2.5", "nose>=1.3.7"]
Would you mind if I make a pull request removing this <2
constraint on this file?
@harsharahul Can we please get a release with a corrected pyjwt
pin? Most people use docusign-esign
as library with an app: it's not a standalone product. They need to manage many dependencies, and dependencies of dependencies, and can do so efficiently using tools like pip-tools
, safety
etc. Manually installing a different version of pyjwt does not work, since that forces you to abandon the existing workflow with named tools, and also forces you to disable all kinds of other sanity checks that are done by default on deployments, like pip check
etc.
The invalid pin in setup.py
effectively prevents us from using release 3.18.0, forcing us to stay at 3.17.0.
@mondaini @whyscream Thank you for your patience. The new version with the updated setup.py
file is released to the package managers. Please using v3.18.1.
-Harsha
Hi @harsharahul,
The release
3.18.0
forces thepyjwt
version to be lower than version 2. Is it mandatory?I have one project with other dependencies conflicting with that constraint:
I understand I can roll back to the previous docusign-esign release, but I'd like to be up to date whenever possible.
Thank you for your support.
Originally posted by @mondaini in https://github.com/docusign/docusign-esign-python-client/issues/150#issuecomment-1252497775