search

docusign / docusign-esign-python-client

The Official DocuSign Python Client Library used to interact with the eSign REST API. Send, sign, and approve documents using this client. https://www.docusign.com/devcenter
MIT License
92 stars 88 forks source link

Python 3.12 support (replace nose with pynose) #186

Open gjcarneiro opened 2 months ago

gjcarneiro commented 2 months ago

Hi, this package seems to require nose. However, nose is no longer maintained and doesn't work in Python 3.12.

REQUIRES = ["urllib3 >= 1.15", "six >= 1.8.0", "certifi >= 14.05.14", "python-dateutil >= 2.5.3", "setuptools >= 21.0.0", "PyJWT>=2.0.0", "cryptography>=2.5", "nose>=1.3.7"]

I suggest we could replace it with pynose instead?... It has the same API and module name, but is made to work with more modern Pythons.

ByungjaeChung commented 2 months ago

Thanks for the info. I've created the enhancement ticket DCM-11778 for engineering, and they'll investigate a possible fix for this issue.

gjcarneiro commented 1 month ago

Actually, could you instead just remove nose from the package requirements?

nose is only used for running tests, and it's already listed in test-requirements.txt.