docusign / docusign-objc-client

The Official DocuSign Objective-C Client Library used to interact with the eSign REST API. Send, sign, and approve documents using this client.
https://www.docusign.com/devcenter
MIT License
13 stars 14 forks source link

Unnecessarily return value in Methods #15

Closed toseefkhilji closed 4 years ago

toseefkhilji commented 6 years ago

Hi,

There are Unnecessarily return values in API class (i.e DSAuthenticationApi, DSEnvelopesApi, DSBillingApi, DSFoldersApi, etc.) Methods. Because there is already completionHandlers.

For example:

-(NSNumber*) listSocialLoginsWithAccountId:
(NSString*) accountId  userId:(NSString*) userId 
 completionHandler: (void (^)(DSUserSocialIdResult* output, NSError* error)) handler;

-(NSNumber*) revokeOAuthTokenWithCompletionHandler: (void (^)(NSError* error)) handler;

It should be

-(void) listSocialLoginsWithAccountId:
(NSString*) accountId  userId:(NSString*) userId 
 completionHandler: (void (^)(DSUserSocialIdResult* output, NSError* error)) handler;

-(void) revokeOAuthTokenWithCompletionHandler: (void (^)(NSError* error)) handler;
LarryKlugerDS commented 4 years ago

Thank you for your comment. The SDK is auto-generated by the Swagger CodeGen tool. Unfortunately it does include some redundant data in the generated SDK.

Unfortunately, we don't plan to enhance the tool to correct this issue.