docusign / native-ios-sdk

A set of official UI components along with programmable client libraries that enable developers to integrate their products with DocuSign’s signature service API on iOS
https://docusign.github.io/native-ios-sdk/documentation/docusignsdk/
Other
27 stars 27 forks source link

Captive Signing doesn't load on iOS 16.0 #166

Closed ajrotert closed 2 months ago

ajrotert commented 3 months ago

Issue: Captive Signing doesn't finish loading on iOS 16.0

        guard let viewController = UIApplication.shared.activeWindow?.rootViewController?.topPresentedViewController() else { return .failed }

        DSMEnvelopesManager().presentCaptiveSigning(
            withPresenting: viewController,
            signingUrl: signingUrl.absoluteString,
            envelopeId: envelopeId,
            recipientId: nil,
            animated: true
        )

Reproduce:

Call presentCaptiveSigning on an iOS 16.0 simulator or device.

Screenshot:

image

Video:

https://github.com/docusign/native-ios-sdk/assets/44625749/55460350-72a3-4689-93b1-5eb9f5e598af

Expected:

Video on iOS 17

https://github.com/docusign/native-ios-sdk/assets/44625749/f553249b-317c-452b-8ce5-ad46f517bb7f

esilva600 commented 3 months ago

Hello,

The article below shows a walkthrough on how to perform Embedded Signing on iOS: https://www.docusign.com/blog/developers/embedded-signing-the-native-ios-sdk

If further assistance is needed, you need to log a ticket and reach out to the DocuSign Mobile Integrations Team

ajrotert commented 3 months ago

Hello,

The article below shows a walkthrough on how to perform Embedded Signing on iOS: https://www.docusign.com/blog/developers/embedded-signing-the-native-ios-sdk

If further assistance is needed, you need to log a ticket and reach out to the DocuSign Mobile Integrations Team

Where can I reach out to the DocuSign Mobile Integrations Team? I believe that this is an issue with the SDK, as it works on iOS17, but doesn't on iOS16.

Thanks

ashokds commented 3 months ago

Hi @ajrotert & @esilva600 :

Thanks for adding the details on this issue.

Will investigate the issue and post update here.

ashokds commented 3 months ago

Hi @ajrotert :

Could you try again on iOS16 simulator as there was a known backend issue that obstructed the Embedded Signing to finish loading on iOS 16 and earlier. It's been resolved since then.

Thanks!

ashokds commented 2 months ago

Closing this as underlying incident was fixed.

jonathansds commented 3 weeks ago

It's still happening for me. The initial screen even loads behind but the loading spinner is not dismissed. I am testing on iOS 17.5

Simulator Screenshot - iPhone 15 Pro - 2024-09-06 at 10 15 03

mmohareb commented 3 weeks ago

Hello @jonathansds I think this is a different issue, can you open a new issue with more details about how you are starting the signing session and maybe a code snippet with a recording of the whole flow, to make it possible for us to investigate?

jonathansds commented 3 weeks ago

I still believe it's the same issue but in any case, I created a new issue here: https://github.com/docusign/native-ios-sdk/issues/171