docwilmot / menu_block

GNU General Public License v2.0
0 stars 1 forks source link

Planning to make this an official Backdrop port? #1

Open jackaponte opened 7 years ago

jackaponte commented 7 years ago

I was glad to find this port; after a bit of fiddling and figuring out I was able to install it and use it successfully on a Backdrop 1.5.0 site! (The site throws some PHP notices, but I think that's a Backdrop core bug introduced in the recent release; I'll be filing a core issue/pull request soon.)

Anyhow, the fact that the module is nearly working is great, but I can see that a few things (e.g. the README.txt file) need a bit of work before this can be considered fully ported. Do you have plans to officially port this to Backdrop anytime soon?

Either way, many thanks!

docwilmot commented 7 years ago

most menu block features were actually merged into core. Features removed:

Everything else is in core. So if we're going to do anything more, would be a contrib module to add these missing features. To be honest I no longer really understand what these "features" all mean. If you need the missing features and understand what they do, then I'd be happy if you took this over.

jackaponte commented 7 years ago

Thanks for the clarification, @docwilmot; sorry to take so long in responding again!

Somehow I missed that most of the menu_block features are now in core! I don't actually need the removed features that you mention in your earlier update.

I tried creating a main menu block with both core and menu_block and in theory, menu_block offers one thing that I need that core doesn't offer: the "Block title as link" option that appears under "Advanced option" when configuring a menu block. Ideally I'd like the "Main menu" block title to be a link to that menu item.

However, in practice the core functionality works just as well, because that "Block title as link" option in the menu_block module isn't working!

I'm not sure if it would be better to create a contrib module just to get the block title as a link, but I have no idea if that's a reasonable feature request for core (or how long that would take!)

Any thoughts on which way to proceed from here?

ghost commented 3 years ago

@docwilmot I'd suggest moving this repo to the contrib group so at least it can be found by people easier. Might get more help then. Took me ages to find this (only did so from an issue in the Drupal issue queue).