docyx / pc-part-dataset

A dataset of PC parts scraped from PCPartPicker
MIT License
173 stars 41 forks source link

fix boost_clock serialization map to match new page layout #9

Closed guipace closed 8 months ago

guipace commented 8 months ago

The key on this line needs to be updated from Performance Boost Clock to Performance Core Boost Clock; PCPP changed their column heading.

I tried creating a PR for this, but doesn't seem like it's possible to contribute to this repo.

https://github.com/docyx/pc-part-dataset/blob/53cd6c1b890679a065e0cd7cd2a13b51ba4ff3d4/src/serialization-map.json#L5C32-L5C43

image
docyx commented 8 months ago

4908df9e63fc98bafea4d1465447bfd05466fb47 fixes this.

I tried creating a PR for this, but doesn't seem like it's possible to contribute to this repo.

Can you elaborate on this? Did you get an error or something?

guipace commented 8 months ago

I got the following error trying to push a branch:

git push --set-upstream origin gp/fix_serialization_map_cpu
remote: Permission to docyx/pc-part-dataset.git denied to guipace.
fatal: unable to access 'https://github.com/docyx/pc-part-dataset.git/': The requested URL returned error: 403
docyx commented 8 months ago

Try forking?

guipace commented 8 months ago

The intent was to collaborate on this repo instead of forking and maintaining it separately.

docyx commented 8 months ago

This is what I mean:

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

I can't just let anyone push a change without approval. You can fork and then submit a PR through it.