search

doczjs / docz

✍ It has never been so easy to document your things!
https://docz.site
MIT License
23.6k stars 1.45k forks source link

Update react-hot-loader #645

Closed korywka closed 4 years ago

korywka commented 5 years ago

Bug Report

React hook useEffect is broken

https://github.com/facebook/react/issues/14767#issuecomment-461118304

korywka commented 5 years ago

image

=> Found "react-hot-loader@4.3.6"
info Reasons this module exists
   - "docz-plugin-css#docz-core" depends on it
   - Hoisted from "docz-plugin-css#docz-core#react-hot-loader"
info Disk size without dependencies: "152KB"
info Disk size with unique dependencies: "480KB"
info Disk size with transitive dependencies: "880KB"
info Number of shared dependencies: 10
=> Found "docz#react-hot-loader@4.7.0"
info Reasons this module exists
   - "docz#docz-core" depends on it
   - Hoisted from "docz#docz-core#react-hot-loader"
info Disk size without dependencies: "228KB"
info Disk size with unique dependencies: "1.63MB"
info Disk size with transitive dependencies: "2.21MB"
info Number of shared dependencies: 16
✨  Done in 0.83s.
korywka commented 5 years ago

Workaround:

"resolutions": {
    "docz-core": "^0.13.7"
  }
Grsmto commented 5 years ago

I had to pop other stuff to get it working:

"resolutions": {
    "react-hot-loader": "4.7.1",
    "docz-core": "^0.13.7",
    "ansi-styles": "^3.2.0"
  },
"devDependencies": {
  "@emotion/cache": "^10.0.0",
  "@emotion/core": "^10.0.6"
}

Feels super dodgy but works for now 🙏