dod-cyber-crime-center / pyhidra

Pyhidra is a Python library that provides direct access to the Ghidra API within a native CPython interpreter using jpype.
Other
153 stars 14 forks source link

application.properties parsing too strict #12

Closed goatshriek closed 2 years ago

goatshriek commented 2 years ago

The parsing of the Ghidra install's application.properties file is more restrictive than Ghidra, which uses the Java Properties class to load the file. This could lead to problems in customized Ghidra installations where the properties file has been modified in keeping with this format, for example by adding comment lines starting with # and no assignment.

There are multiple ways to resolve this, from doing your own parsing to adding a dependency to do it, to just making the parsing more lenient. I will submitt a pull request for the last of these options shortly, as it is a minor change and will make the properties parsing much more resilient.