search

dod-cyber-crime-center / pyhidra

Pyhidra is a Python library that provides direct access to the Ghidra API within a native CPython interpreter using jpype.
Other
176 stars 15 forks source link

support jpype kwargs #25

Closed clearbluejar closed 1 year ago

clearbluejar commented 1 year ago

Initial attempt to support jpype kwargs. #23

  1. Removed auto add of IgnoreUnrecognizedVMOptions.
  2. Added jpype_kwargs to launcher.start only. If you want to change the defaults, users will need to instantiate a custom launcher. The default pyhidra.start has not changed.
  3. Added 3 tests, 2 working and 1 not quite. The test test_invalid_vm_arg_fail actually breaks the jpype jvm and any subsequent test is not able to run as a result. If the test is run in its own process, it might be able to succeed. Not quite sure how to do that well with pytest.
dc3-tsd commented 1 year ago

Thanks for the PR. We added a few review comments. Can you please also edit the CHANGELOG.md adding a "Unreleased" section at the top with a blurb about what this change provides?