Adds multiple path options for cross-arch support

dod-cyber-crime-center / pyhidra

Pyhidra is a Python library that provides direct access to the Ghidra API within a native CPython interpreter using jpype.

Other

153 stars 14 forks source link

Adds multiple path options for cross-arch support #6

Closed lacraig2 closed 2 years ago

lacraig2 commented 2 years ago

This PR replaces the hardcoded jvm.dll path that presented an issue in #2 with a set of options based on platform.

It adds a default case that uses the default jvm path.

Only tested on environment specified.

Target: OSX 11.6.4, Python 3.7.6, Ghidra 10.2 DEV

FIXES: #2

dc3-tsd commented 2 years ago

Sorry for the slow response. We ended up using a different fix for this, but appreciate you sending this and making us aware of the issue. Please let us know if it works, and if so we will close this pull request and mark the associated issue as resolved.

lacraig2 commented 2 years ago

The solution in main doesn't seem to quite work. See discussion in #2.