cmd update dpg-copyright: and/or output from licensecheck causes error. - Githubissues

dod38fr / config-model

Perl module to create configuration editor with semantic validation

58 stars 12 forks source link

cmd update dpg-copyright: and/or output from licensecheck causes error. #27

Closed rerdavies closed 3 years ago

rerdavies commented 3 years ago

Offending value: 'Please fill license CC-BY-SA-4.0 and/or ISC from header of react/node_modules/glob/' Error: Data extracted from source file is corrupted: Configuration item 'Files:"react/node_modules/glob/" License short_name' has a wrong value: value 'CC-BY-SA-4.0 and/or ISC' does not match grammar from model

Particularly paitful because it takes about 15 minutes to run. So I have to override the license, and wait 15 minutes to get the next error caused by a dual-licensed package.

dod38fr commented 3 years ago

Right... This "and/or" output from licensecheck is troublesome although I understand why licensecheck cannot decide whether a "or" or a "and" should be used.

This problem is made worse because licensecheck takes a lot of time to parse files. I guess a cache would really improve this problem (A cache using a md5 key of the file content could be quite useful)

What I can do:

allow "and/or" and issue a warning when this value is returned by license
add a cache for licensecheck results.

What do you think ?

dod38fr commented 3 years ago

@rerdavies What version of libconfig-model-dpkg-perl are you using ?

dod38fr commented 3 years ago

@rerdavies and which debian package triggered this bug ? So I can reproduce this bug.

dod38fr commented 3 years ago

Adding a cache to licensecheck requires launching this command for each scanned file. The performance is disappointing. So the cache cannot be implemented in cme

dod38fr commented 3 years ago

A fix for a crash related to and/or was released with libconfig-model-dpkg-perl 2.152.