search

dod38fr / config-model

Perl module to create configuration editor with semantic validation
58 stars 12 forks source link

Exception::Class was not removed completly #5

Closed jplesnik closed 8 years ago

jplesnik commented 8 years ago

The Exception::Class is still used in Config::Model::Warper

lib/Config/Model/Warper.pm: L569: if ( my $e = Exception::Class->caught($expected_error) ) {

Is it correct or should it be replaced?

dod38fr commented 8 years ago

Oops... It should be replaced.

Thanks for the heads-up

dod38fr commented 8 years ago

@jplesnik I'd like to know how you found this issue. Was it by reading code or did you get an error ?

All the best

jplesnik commented 8 years ago

I was updating Fedora package to the latest version. Before I removed Exception::Class from build-requires, I just checked via grep if Exception::Class is no using in code. I did not get any error.

dod38fr commented 8 years ago

Interesting. I did not know that Config::Model was now up-to-date on Fedora. That's very good news. :smiley:

I'll fix this issue asap (I need to check whether this code is dead or not).

BTW, feel free to ask for changes that may ease your work as Fedora packager (As Debian packager, I know that upstream can help a lot in our day-to-day activities)

All the best

dod38fr commented 8 years ago

Fixed in v2.079