dod38fr / config-model

Perl module to create configuration editor with semantic validation
58 stars 12 forks source link

Test the build and the distribution on travis #9

Closed jluis closed 8 years ago

jluis commented 8 years ago

After reading the documentation that @dod38fr pointed me in order to complete my CPAN PRC (isue 8) I tried to build from github and noticed that it wasn't as easy as piping Dist::Zilla output to cpanminus :smile:

That is the result of my test that shall also help me to update README.build-from-git

I left the history of my commits (are more commits than lines in the .travis.yml file) and the travis tests are on https://travis-ci.org/jluis/config-model

Thanks for you time

dod38fr commented 8 years ago

That's a very good start :+1:

To dot the legal "i" and cross the legal "t", could you specify that you're releasing your contributions under the same terms as config-model project (e.g. LGPL-2.1 or later) ? I don't mind you keeping copyright. (it may well be that my Debian developer side is a little bit too picky, but I would be more comfortable with such a statement from you.)

All the best

jluis commented 8 years ago

Sure I release all my PR under the same license that the project I send the pull request to. Also I don't mid giving you the copyright to you.

How I do it? is this statement sufficient to you? I need to put a note on the file? on every pr the PR?

Thanks for your fast feedback.

dod38fr commented 8 years ago

Yes. that's enough. I'm going to merge.

Thanks for your PR :-)