search

doddo / octodns-lexicon

Use Lexicon providers in OctoDNS
MIT License
12 stars 2 forks source link

Pulling records using lexicon should ensure trailing dot #3

Closed brianeclow closed 4 years ago

brianeclow commented 4 years ago

Using the godaddy provider:

octodns.record.ValidationError: Invalid record @.example.com.
  - NS value "ns93.domaincontrol.com" missing trailing .
  - NS value "ns94.domaincontrol.com" missing trailing .

The Rackspace provider for octoDNS had a similar problem, due to how the provider stores the entries. The defs were added.

However, this might not be ideal for all providers. 😞

doddo commented 4 years ago

Indeed, there are some inconsistencies between Lexicon providers, but It should be a simple enough fix, I think. If one can reasonably assume that "ns94.domaincontrol.com" should be treated as FQDN and not a relative entry.

doddo commented 4 years ago

@brianeclow could you try and see if this fixes the issue you are facing?

doddo commented 4 years ago

Root cause seems to be in the godaddy provider: https://github.com/AnalogJ/lexicon/issues/518

brianeclow commented 4 years ago

Let me pull and test. But in light of the lexicon issue, it might be a problem. I will also update the pinned version to the one indicated in their issue.

brianeclow commented 4 years ago

That combination has gotten me to the next issue. Which I think resides with how, um, relaxed godaddy is with enforcing the RFCs for DNS. 🤦

doddo commented 4 years ago

Is that related to that default forward record or suchlike which godaddy populates new zones with. -- there's a lenient boolean option you can set on the provider and it's not gonna crash on invalid records 👍

brianeclow commented 4 years ago

I've hit it on two things: the "forward" record as A Record, and their laziness on MX records.

How do you add lenient to this provider? I am not finding much documentation on where/how to add it.

brianeclow commented 4 years ago

I used my existing configuration, but did a dump passing in the --lenient flag. It still barfs on the MX records. Someone isn't playing nice.

doddo commented 4 years ago

yes I saw that and can confirm that Godaddy lexicon provider does not handle MX records extra fields very good unfortunatly.