dodevops / cloudcontrol

The cloud engineer's toolbox ☁️ 🧰
MIT License
17 stars 4 forks source link

BUG: "krew" feature installer not working #142

Closed salami738 closed 3 months ago

salami738 commented 3 months ago

Our config file is

version: "3"
services:
    cli:
        image: "ghcr.io/dodevops/cloudcontrol-azure:latest"
...
        environment:
            - "FEATURES=kubernetes terraform:1.7.5 helm:3.14.0 stern:1.28.0 fish kc kubectlnodeshell azcopy krew"
...
            - "USE_run=yes"
            - 'RUN_COMMANDS=source /terraform/cloudcontrol-template/christ_webshop/project_commands'

If we set up cloudcontrol with this configuration, “krew” will not be installed.

salami738 commented 3 months ago

The feature was added to the variable, but is not installed:

/terraform ➜  echo $FEATURES                                                                                                                                                      environment_dummy () 10:20:02
kubernetes terraform:1.7.5 helm:3.14.0 stern:1.28.0 fish kc kubectlnodeshell azcopy krew

Startup/install logs

$ docker logs e84af2530e36
2024/06/11 10:09:36 Setting bash as default shell
2024/06/11 10:09:36 Starting flavour initialization
2024/06/11 10:09:36 Logging in...
2024/06/11 10:09:38 To sign in, use a web browser to open the page https://microsoft.com/devicelogin and enter the code xxx to authenticate.
2024/06/11 10:09:55 [
  {
...
]
2024/06/11 10:09:55 Setting subscription...
2024/06/11 10:09:55 Preparing bashrc
2024/06/11 10:09:55 Flavour initialization finished
2024/06/11 10:09:55 Installing feature Fish Shell
2024/06/11 10:09:55 Installing packages
2024/06/11 10:09:55 Installing fish...
2024/06/11 10:09:57 Installing fisher...
2024/06/11 10:09:58 Installing fish packages...
2024/06/11 10:09:59 Installing spacefish configuration...
2024/06/11 10:09:59 Installing feature AzCopy
2024/06/11 10:09:59 Downloading azcopy...
2024/06/11 10:10:00 Extracting azcopy...
2024/06/11 10:10:00 Installing azcopy...
2024/06/11 10:10:00 Making azcopy executable...
2024/06/11 10:10:00 Installing feature Helm
2024/06/11 10:10:00 Downloading helm...
2024/06/11 10:10:01 Unpacking helm...
2024/06/11 10:10:01 Installing helm...
2024/06/11 10:10:01 Installing feature kc Quick Kubernetes Context switch
2024/06/11 10:10:01 Installing dialog package...
2024/06/11 10:10:02 Installing kc...
2024/06/11 10:10:02 Making kc executable...
2024/06/11 10:10:02 Installing feature Kubectlnodeshell
2024/06/11 10:10:02 Downloading kubectl node-shell...
2024/06/11 10:10:02 Making kubectl node-shell executable...
2024/06/11 10:10:02 Installing kubectl node-shell...
2024/06/11 10:10:02 Installing feature Kubernetes
2024/06/11 10:10:02 Installing kubectl...
2024/06/11 10:10:16 Cluster xxx in resource group xxx
...
2024/06/11 10:10:35 Installing feature Run
2024/06/11 10:10:35 Setting up RUN for fish
2024/06/11 10:10:35 Installing feature Stern
2024/06/11 10:10:35 Downloading stern...
2024/06/11 10:10:36 Unpacking stern...
2024/06/11 10:10:36 Installing stern...
2024/06/11 10:10:36 Installing feature Terraform
2024/06/11 10:10:36 Downloading terraform...
2024/06/11 10:10:37 Unpacking terraform...
2024/06/11 10:10:38 Installing terraform...
2024/06/11 10:10:38 Finished initialization
2024/06/11 10:10:38 Please run the following to enter CloudControl
2024/06/11 10:10:38 docker-compose exec cli /usr/local/bin/cloudcontrol run
dploeger commented 3 months ago

This feature wasn't released yet. Please use the :develop tag to use it for now.

dploeger commented 3 months ago

Actually, I just merged the release PR and if you wait for a few minutes, you can use it in :latest or :6.0.0 as well. 😄